[llvm] r309919 - [unittest] Remove TODO comment which caused concern

Tobias Grosser via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 2 21:17:58 PDT 2017


Author: grosser
Date: Wed Aug  2 21:17:58 2017
New Revision: 309919

URL: http://llvm.org/viewvc/llvm-project?rev=309919&view=rev
Log:
[unittest] Remove TODO comment which caused concern

Remove the second part of the TODO comment that highlighted an issue with
possibly connecting all nodes to the exit of the CFG. This caused concerns
with Jakub Kuderski regarding its feasability, hence we remove it. Such
points are better discussed outside of CFG. If connecting all nodes makes
sense and what the impact is is currently part of an active review discussion.

Modified:
    llvm/trunk/unittests/IR/DominatorTreeTest.cpp

Modified: llvm/trunk/unittests/IR/DominatorTreeTest.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/IR/DominatorTreeTest.cpp?rev=309919&r1=309918&r2=309919&view=diff
==============================================================================
--- llvm/trunk/unittests/IR/DominatorTreeTest.cpp (original)
+++ llvm/trunk/unittests/IR/DominatorTreeTest.cpp Wed Aug  2 21:17:58 2017
@@ -454,7 +454,7 @@ TEST(DominatorTree, DeletingEdgesIntrodu
 // PDT. We also verify this property.
 //
 // TODO: Can we change the PDT definition such that C remains part of the
-//       CFG, at best without loosing the dominance relation D postdom B.
+//       CFG?
 TEST(DominatorTree, DeletingEdgesIntroducesInfiniteLoop) {
   StringRef ModuleString =
       "define void @f() {\n"




More information about the llvm-commits mailing list