[PATCH] D36203: [zorg] Add buildbot with reverse iteration enabled

Victor Leschuk via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 2 20:54:33 PDT 2017


vleschuk added inline comments.


================
Comment at: buildbot/osuosl/master/config/builders.py:806
                 jobs=16,
-                checkFormat=False,
                 extraCmakeArgs=["-G", "Ninja",
----------------
grosser wrote:
> pzheng wrote:
> > vleschuk wrote:
> > > Why do you need to change this?
> > This is actually a clean up for the PollyBuilder. The PollyBuilder has a "make polly-check-format" step which is no longer needed since "make check-polly" (or "make check-all" which we are adding) also includes it. Since we are reusing getPollyBuildFactory in the reverse iteration buildbot, it seems to be a good time to clean up the PollyBuiler at the same time.
> I am fine with this change!
That's ok. But I'd prefer more granular commits. Could you please split changes  into separate commits next time?


https://reviews.llvm.org/D36203





More information about the llvm-commits mailing list