[PATCH] D36170: LSR: Fix PR33514

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added a comment.

> If we insert more converts we should raise Formula cost somehow (most likely leading to the formula drop).

Good point. Maybe mention that in the comment and we can revisit if we see test where it is needed later on.

> SCEV expands to undefined value and it seems good enough. The expansion could be in dead code for example - so assert or error is too strict.

Make sense.

> Other tests that have difference in binaries got the same performance.

Interesting, given we were generating invalid code, what changed there?


Repository:
  rL LLVM

https://reviews.llvm.org/D36170