[PATCH] D36201: Merge manifest namespaces.

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: llvm/include/llvm/WindowsManifest/WindowsManifestMerger.h:87-90
 #if LLVM_LIBXML2_ENABLED
   XMLDocumentImpl CombinedDoc = nullptr;
   std::vector<XMLDocumentImpl> MergedDocs;
 #endif
----------------
Perhaps we should hide the implementation details here with the pimpl pattern: http://en.cppreference.com/w/cpp/language/pimpl

Then we don't need to include xmlreader.h above behind ifdefs in the header, and clients will not have to worry about possible name or macro conflicts.

The "Impl" class would store the vector of merged XML documents.


https://reviews.llvm.org/D36201