[PATCH] D36199: [Inliner] Increase threshold for hot callsites without PGO.

[Easwaran Raman via Phabricator via llvm-commits]

eraman added a comment.

In https://reviews.llvm.org/D36199#829276, @chandlerc wrote:

> In https://reviews.llvm.org/D36199#828958, @haicheng wrote:
>
> > Hi  Easwaran,
> >
> > What if the callee of a hot callsite also has a inline hint?
>
>
> (FWIW, my 2 cents here would be that this should win over inline hint, as it should be quite a bit stronger. Anyways, will let Easwaran actually respond as well as I'm curious what he thinks.)


I initially started with a multiplier instead of an absolute threshold, but changed it mainly to be consistent with the PGO based hot callsite. It is definitely a stronger hint, but I think an argument can be made that various "signals" should be composed.


https://reviews.llvm.org/D36199