[PATCH] D36190: [asan] Allocator support for Fuchsia

[Aleksey Shlyapnikov via Phabricator via llvm-commits]

alekseyshl added inline comments.


================
Comment at: lib/asan/asan_malloc_linux.cc:87
+
+#endif // !SANITIZER_FUCHSIA
+
----------------
How about minimizing the ifdefed section and go with this:

  INLINE bool MaybeInDlsym() {
  #if SANITIZER_FUCHSIA
    return false;
  #else
    return asan_init_is_running;
  #endif
  }

Wouldn't the compiler be smart enough to optimize out all that unused stuff? And we will have to do the same for IsInDlsymAllocPool to help it to figure that out.



https://reviews.llvm.org/D36190