[PATCH] D36203: [zorg] Add buildbot with reverse iteration enabled

[Pengxuan Zheng via Phabricator via llvm-commits]

pzheng added inline comments.


================
Comment at: buildbot/osuosl/master/config/builders.py:806
                 jobs=16,
-                checkFormat=False,
                 extraCmakeArgs=["-G", "Ninja",
----------------
vleschuk wrote:
> Why do you need to change this?
This is actually a clean up for the PollyBuilder. The PollyBuilder has a "make polly-check-format" step which is no longer needed since "make check-polly" (or "make check-all" which we are adding) also includes it. Since we are reusing getPollyBuildFactory in the reverse iteration buildbot, it seems to be a good time to clean up the PollyBuiler at the same time.


================
Comment at: zorg/buildbot/builders/PollyBuilder.py:30
+    check_all_cmd = [make, 'check-all'] + jobs_cmd
+    check_polly_cmd = [make, 'check-polly'] + jobs_cmd
     cmake_install = []
----------------
vleschuk wrote:
> How are these changes related to adding reverse iterations builder?
We want to add a "make check-all" step in the reverse iterator buildbot, but only "make check-polly" is available in getPollyBuildFactory currently. Therefore we are introducing "checkAll" to control whether to run "make check-all" or "make check-polly". "checkAll" defaults to false which is the desired behavior for existing Polly builders. For the reverse iteration buildbot, "checkAll" is set to true to run "make check-all" instead of "make check-polly".


https://reviews.llvm.org/D36203