[PATCH] D35524: [AMDGPU] Add support for Whole Wavefront Mode

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/SIInstructions.td:133
 
+def EXIT_WWM : SPseudoInstSI <(outs SReg_64:$exec), (ins SReg_64:$src0)> {
+  let hasSideEffects = 0;
----------------
I think you should keep the out name to match others, i.e. $sdst


================
Comment at: lib/Target/AMDGPU/SIWholeQuadMode.cpp:713
 bool SIWholeQuadMode::runOnMachineFunction(MachineFunction &MF) {
-  if (MF.getFunction()->getCallingConv() != CallingConv::AMDGPU_PS)
-    return false;
----------------
Why remove this? It should definitely exit early for compute


https://reviews.llvm.org/D35524