[PATCH] D35936: [ELF] - Move getSymbols() method to InputFile.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 2 10:42:06 PDT 2017


After r309840 it should be possible to merge all the getSymbols and
the storage they use into the base class I think.

Cheers,
Rafael

Rui Ueyama via Phabricator <reviews at reviews.llvm.org> writes:

> ruiu added a comment.
>
> Overall, it doesn't seem like an improvement. You don't need to push too hard to remove templates. Use of templates is not necessarily bad.
>
> That being said, if you think that this change could remove a lot of uses of templates, please do that in this patch to demonstrate it.
>
>
> https://reviews.llvm.org/D35936


More information about the llvm-commits mailing list