[llvm] r309833 - Revert "[lit] Avoid copying llvm/utils/lit/tests/Inputs with lit site configs"

[Reid Kleckner via llvm-commits]

Author: rnk
Date: Wed Aug  2 10:16:25 2017
New Revision: 309833

URL: http://llvm.org/viewvc/llvm-project?rev=309833&view=rev
Log:
Revert "[lit] Avoid copying llvm/utils/lit/tests/Inputs with lit site configs"

This reverts r309602, check-lit still leaves Output directories in the
source directory.

Added:
    llvm/trunk/utils/lit/CMakeLists.txt
Removed:
    llvm/trunk/utils/lit/tests/CMakeLists.txt
    llvm/trunk/utils/lit/tests/Inputs/lit.site.cfg.in
Modified:
    llvm/trunk/CMakeLists.txt
    llvm/trunk/utils/lit/tests/lit.site.cfg.in

Modified: llvm/trunk/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/CMakeLists.txt?rev=309833&r1=309832&r2=309833&view=diff
==============================================================================
--- llvm/trunk/CMakeLists.txt (original)
+++ llvm/trunk/CMakeLists.txt Wed Aug  2 10:16:25 2017
@@ -897,7 +897,7 @@ if( LLVM_INCLUDE_TESTS )
       NO_INSTALL
       ALWAYS_CLEAN)
   endif()
-  add_subdirectory(utils/lit/tests)
+  add_subdirectory(utils/lit)
   add_subdirectory(test)
   add_subdirectory(unittests)
   if( LLVM_INCLUDE_UTILS )

Added: llvm/trunk/utils/lit/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/CMakeLists.txt?rev=309833&view=auto
==============================================================================
--- llvm/trunk/utils/lit/CMakeLists.txt (added)
+++ llvm/trunk/utils/lit/CMakeLists.txt Wed Aug  2 10:16:25 2017
@@ -0,0 +1,27 @@
+# The configured file is not placed in the correct location
+# until the tests are run as we need to copy it into
+# a copy of the tests folder
+configure_file("tests/lit.site.cfg.in" "lit.site.cfg" @ONLY)
+
+# Lit's test suite creates output files next to the sources which makes the
+# source tree dirty. This is undesirable because we do out of source builds.
+# To work around this the tests and the configuration file are copied into the
+# build directory just before running them. The tests are not copied over at
+# configure time (i.e. `file(COPY ...)`) because this could lead to stale
+# tests being run.
+add_custom_target(prepare-check-lit
+  COMMAND ${CMAKE_COMMAND} -E remove_directory "${CMAKE_CURRENT_BINARY_DIR}/tests"
+  COMMAND ${CMAKE_COMMAND} -E copy_directory "${CMAKE_CURRENT_SOURCE_DIR}/tests" "${CMAKE_CURRENT_BINARY_DIR}/tests"
+  COMMAND ${CMAKE_COMMAND} -E copy "${CMAKE_CURRENT_BINARY_DIR}/lit.site.cfg" "${CMAKE_CURRENT_BINARY_DIR}/tests"
+  COMMENT "Preparing lit tests"
+)
+
+# Add rules for lit's own test suite
+add_lit_testsuite(check-lit "Running lit's tests"
+  ${CMAKE_CURRENT_BINARY_DIR}
+  DEPENDS "FileCheck" "not" "prepare-check-lit"
+)
+
+# For IDEs
+set_target_properties(check-lit PROPERTIES FOLDER "Tests")
+set_target_properties(prepare-check-lit PROPERTIES FOLDER "Tests")

Removed: llvm/trunk/utils/lit/tests/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/tests/CMakeLists.txt?rev=309832&view=auto
==============================================================================
--- llvm/trunk/utils/lit/tests/CMakeLists.txt (original)
+++ llvm/trunk/utils/lit/tests/CMakeLists.txt (removed)
@@ -1,24 +0,0 @@
-# The configured file is not placed in the correct location
-# until the tests are run as we need to copy it into
-# a copy of the tests folder
-configure_file("lit.site.cfg.in" "lit.site.cfg" @ONLY)
-
-# For every lit.cfg in the Inputs tree, create a lit.site.cfg that points at
-# the tests back in the source directory. Running the tests this way keeps the
-# temporary output files in the build directory.
-file(GLOB inputs_suites "Inputs/*/lit.cfg")
-foreach(lit_cfg ${inputs_suites})
-  get_filename_component(LIT_TEST_SRC_DIR "${lit_cfg}" DIRECTORY)
-  file(RELATIVE_PATH LIT_TEST_BIN_DIR "${CMAKE_CURRENT_SOURCE_DIR}" "${LIT_TEST_SRC_DIR}")
-  set(LIT_TEST_BIN_DIR "${CMAKE_CURRENT_BINARY_DIR}/${LIT_TEST_BIN_DIR}")
-  configure_file("Inputs/lit.site.cfg.in" "${LIT_TEST_BIN_DIR}/lit.site.cfg" @ONLY)
-endforeach()
-
-# Add rules for lit's own test suite
-add_lit_testsuite(check-lit "Running lit's tests"
-  ${CMAKE_CURRENT_BINARY_DIR}
-  DEPENDS "FileCheck" "not"
-)
-
-# For IDEs
-set_target_properties(check-lit PROPERTIES FOLDER "Tests")

Removed: llvm/trunk/utils/lit/tests/Inputs/lit.site.cfg.in
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/tests/Inputs/lit.site.cfg.in?rev=309832&view=auto
==============================================================================
--- llvm/trunk/utils/lit/tests/Inputs/lit.site.cfg.in (original)
+++ llvm/trunk/utils/lit/tests/Inputs/lit.site.cfg.in (removed)
@@ -1,3 +0,0 @@
-lit_config.load_config(config, "@LIT_TEST_SRC_DIR@/lit.cfg")
-config.test_source_root = "@LIT_TEST_SRC_DIR@"
-config.test_exec_root = "@LIT_TEST_BIN_DIR@"

Modified: llvm/trunk/utils/lit/tests/lit.site.cfg.in
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/tests/lit.site.cfg.in?rev=309833&r1=309832&r2=309833&view=diff
==============================================================================
--- llvm/trunk/utils/lit/tests/lit.site.cfg.in (original)
+++ llvm/trunk/utils/lit/tests/lit.site.cfg.in Wed Aug  2 10:16:25 2017
@@ -5,6 +5,4 @@ config.llvm_obj_root = "@LLVM_BINARY_DIR
 config.llvm_tools_dir = "@LLVM_TOOLS_BINARY_DIR@"
 
 # Let the main config do the real work.
-lit_config.load_config(config, "@LLVM_SOURCE_DIR@/utils/lit/tests/lit.cfg")
-config.test_source_root = "@CMAKE_CURRENT_SOURCE_DIR@"
-config.test_exec_root = "@CMAKE_CURRENT_BINARY_DIR@"
+lit_config.load_config(config, "@LLVM_BINARY_DIR@/utils/lit/tests/lit.cfg")