[PATCH] D35672: [XRay] [test-suite] Don't use llvm_multisource macro for XRay tests and use .test files

[Matthias Braun via Phabricator via llvm-commits]

MatzeB accepted this revision.
MatzeB added a comment.

LGTM when you switch to `llvm_test_executable()`, thanks.



================
Comment at: MicroBenchmarks/XRay/CMakeLists.txt:5-7
+  SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11 -Wl,--gc-sections -fxray-instrument")
+  SET(CMAKE_EXE_LINKER_FLAGS  "${CMAKE_EXE_LINKER_FLAGS} -fxray-instrument")
+  add_executable(retref-bench retref-bench.cc)
----------------
You should use `llvm_test_executable()` instead of `add_executable`. That way you can keep using `list(APPEND CPPFLAGS)` and will automatically get some dependencies right (everything in the test-suite has to depend on the time-it tool, as we use that to measure the compile time).



https://reviews.llvm.org/D35672