[PATCH] D36219: [ARM] Tidy up banked registers encoding

Diana Picus via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 2 07:34:42 PDT 2017


rovka added inline comments.


================
Comment at: lib/Target/ARM/Utils/ARMBaseInfo.cpp:46
+  namespace ARMBankedReg {
+#define GET_BANKEDREG_IMPL
+#include "ARMGenSystemRegister.inc"
----------------
fhahn wrote:
> not sure what the correct indentation for macros is, but this seems slightly inconsistent with lib/Target/ARM/Utils/ARMBaseInfo.h:69, where it was aligned with the code.
It's consistent with the indentation above, for GET_MYCLASSSYSTREG_IMPL, so if you change one you should change both.
While we're discussing indentation, I think we don't usually indent a namespace within a namespace, so both ARMSysReg and ARMBankedReg should be unindented here (luckily, the code in ARMSysReg isn't indented, so it would be a tiny fix).


https://reviews.llvm.org/D36219





More information about the llvm-commits mailing list