[PATCH] D34719: [AMDGPU] Implement llvm.amdgcn.set.inactive intrinsic

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle accepted this revision.
nhaehnle added a comment.
This revision is now accepted and ready to land.

One comment, apart from that LGTM.



================
Comment at: lib/Target/AMDGPU/SIWholeQuadMode.cpp:401-404
+  if (GlobalFlags & StateWQM) {
+    for (MachineInstr *MI : SetInactiveInstrs)
+      markInstruction(*MI, StateWQM, Worklist);
+  }
----------------
Hmm. so automatic propagation of the WQM bit doesn't cover this? It would be nicer if it did, but I don't think it's a big deal in practice. Could you please add an explanatory comment in the code?


https://reviews.llvm.org/D34719