[PATCH] D36201: Merge manifest namespaces.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 1 22:14:31 PDT 2017


ruiu added a comment.

Before looking into details, there are a few things I want to say.

- This is a large patch but the commit message is too terse. Please write it to describe what this patch does.
- Now you have a lot of functions that are individually guarded by #ifdef's, which is somewhat error-prone. It is probably better to have one larger #ifdef and put all functions that are called only when libxml is available into it.


https://reviews.llvm.org/D36201





More information about the llvm-commits mailing list