[PATCH] D36188: [PM] Fix a bug where through CGSCC iteration we can get infinite-inlining across multiple runs of the inliner by keeping a tiny history of internal-to-SCC inlining decisions.
Sanjoy Das via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 1 18:39:43 PDT 2017
sanjoy accepted this revision.
sanjoy added inline comments.
================
Comment at: lib/Transforms/IPO/Inliner.cpp:983
+ // structure, the infinite inlining problem can manifest through infinite
+ // SCC refinement. To avoid this, we capture the originating caller node
+ // and the SCC containing the call edge. This is a slight over
----------------
"infinite refinement" can be a bit confusing since it is easy to think refinement is monotonic (in particular, I would not classify SCC splits as refinement). How about "infinite SCC splits and merges"?
https://reviews.llvm.org/D36188
More information about the llvm-commits
mailing list