[PATCH] D36195: Fix the bug that parseAAPipeline is not invoked in runNewPMPasses in release compiler.

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 1 16:43:41 PDT 2017


davide added a comment.

Wondering whether that should be a `report_fatal_error` instead of `llvm_unreachable`? (as I did in `runNewPMCustomPasses`).
[apologies if I'm missing something, I have this code out of cache and my head deep in GVN today].

Also, either 1) or 2) is fine. I'd prefer 2), and I'd really prefer this to be now. If it's too trouble, maybe open a PR and add a FIXME here.
I understand this is blocking a lot of people, so, if Chandler is OK, this can go in as is (with my previous comments addressed).

BTW, thanks for catching this braino!


https://reviews.llvm.org/D36195





More information about the llvm-commits mailing list