[PATCH] D36190: [asan] Allocator support for Fuchsia

Kostya Kortchinsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 1 14:45:47 PDT 2017


cryptoad added inline comments.


================
Comment at: lib/asan/asan_allocator.h:122
 #if SANITIZER_CAN_USE_ALLOCATOR64
-# if defined(__powerpc64__)
+# if SANITIZER_FUCHSIA
+const uptr kAllocatorSpace = ~(uptr)0;
----------------
Random question:
`SANITIZER_CAN_USE_ALLOCATOR64` is false for `__aarch64__`  by default (https://github.com/llvm-mirror/compiler-rt/blob/master/lib/sanitizer_common/sanitizer_platform.h#L193) except for Android.
I didn't see any change for Fuchsia there (I might have missed it), and as I understand Fuchsia supports AArch64. 
Would setting `SANITIZER_CAN_USE_ALLOCATOR64` for AArch64 in `sanitizer_platform.h` make sense as well?


Repository:
  rL LLVM

https://reviews.llvm.org/D36190





More information about the llvm-commits mailing list