[PATCH] D35865: [asan] Fuchsia port

Roland McGrath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 1 14:30:00 PDT 2017


mcgrathr added inline comments.


================
Comment at: lib/asan/asan_thread.cc:234
+    // because the system itself uses an ASan-aware allocator for that.
+    CHECK(SANITIZER_FUCHSIA);
+    DCHECK_NE(GetCurrentThread(), this);
----------------
vitalybuka wrote:
> Could you please move this into fuchsia version of AsanThread::SetThreadStackAndTls()
Currently I don't have such a function.  It would have to have a different signature than the generic one so it can take the arguments passed to Init.
Or I could make the generic one take optional arguments as I did for Init and always pass them down here.
Is that what you meant?


https://reviews.llvm.org/D35865





More information about the llvm-commits mailing list