[PATCH] D35182: [InstCombine] remove one-use restriction for not (cmp P, A, B) --> cmp P', A, B

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 1 14:07:16 PDT 2017


craig.topper added a comment.

We definitely should do something to fix an invert of a compare feeding an 'and' or 'or' op. I've seen it prevent folding 'and of icmps' or 'or of icmps' because we won't look through the not in those folds. The ones I've seen would have been handled by something like https://reviews.llvm.org/D32725.

This doesn't do anything to fix PR27431 right?

Do we have any real motivating examples that don't involve the compares being used by bitwise operations that https://reviews.llvm.org/D32725 would take care of?


https://reviews.llvm.org/D35182





More information about the llvm-commits mailing list