[PATCH] D36125: Remove PrologEpilogInserter's usage of DBG_VALUE's offset field
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 1 13:47:32 PDT 2017
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
================
Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:992-997
+ DIExpressionCursor Ops(DIExpr);
+ auto Op = Ops.peek();
+ if (Op && Op->getOp() == dwarf::DW_OP_plus_uconst) {
+ Offset = Op->getArg(0);
+ Ops.take();
+ }
----------------
It'd be nice if DIExpressionCursor had a helper for peeling everything that `extractIfOffset` reads.
Repository:
rL LLVM
https://reviews.llvm.org/D36125
More information about the llvm-commits
mailing list