[PATCH] D36110: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 1 13:02:18 PDT 2017


mstorsjo added a comment.

In https://reviews.llvm.org/D36110#826676, @efriedma wrote:

> GCCBuiltin/MSBuiltin emit tables which get used by clang IR generation.  See Intrinsic::getIntrinsicForGCCBuiltin/Intrinsic::getIntrinsicForMSBuiltin.


Thanks for the explanation!

This change looks ok to me. I guess this is a change that isn't too easy to add tests for so I guess it's ok as is?


Repository:
  rL LLVM

https://reviews.llvm.org/D36110





More information about the llvm-commits mailing list