[PATCH] D35919: [AArch64] Rewrite stack frame handling for win64 vararg functions

Tim Northover via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 1 13:00:11 PDT 2017


t.p.northover added inline comments.


================
Comment at: lib/Target/AArch64/AArch64FrameLowering.cpp:512-514
+  // TODO: Should we rename this variable to something else, like RegDumpSize,
+  // to indicate that it covers both the FixedStack for varargs, and the callee
+  // saved regs?
----------------
I'm marginally in favour of all the TODOs, but either way the decision should be made and resolved before committing. FWIW my preferred bikeshed colour would be something like `PrologueSaveSize` or `PrologueStackSize`.


https://reviews.llvm.org/D35919





More information about the llvm-commits mailing list