[PATCH] D35374: AMDGPU: Fix handling of div_scale with undef inputs
    Stanislav Mekhanoshin via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Tue Aug  1 12:35:26 PDT 2017
    
    
  
rampitec added inline comments.
================
Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:3625
     if (!Param)
-      return DAG.getUNDEF(VT);
+      return DAG.getMergeValues({ DAG.getUNDEF(VT), DAG.getUNDEF(MVT::i1) }, DL);
 
----------------
Is it really needed? If the parameter required to be a constant why not just error out?
https://reviews.llvm.org/D35374
    
    
More information about the llvm-commits
mailing list