[PATCH] D35953: [LiveDebugVariables] Use lexical scope to trim debug value live intervals
Adrian Prantl via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 1 12:34:10 PDT 2017
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
Small nitpick on the test, but otherwise this looks good now, thanks!
================
Comment at: test/DebugInfo/X86/live-debug-variables.ll:24
+; CHECK: DW_TAG_inlined_subroutine
+; CHECK: DW_AT_location [DW_FORM_sec_offset] ([[LOC:0x[0-9a-f]+]]){{[[:space:]].*}} "i4"
+; CHECK: [[LOC]]: Beginning address offset
----------------
If you are only checking for `i4`, why are all the other dbg.values necessary? I would expect that we either check for them, too, or that we can remove them to keep the test simple.
https://reviews.llvm.org/D35953
More information about the llvm-commits
mailing list