[PATCH] D35919: [AArch64] Rewrite stack frame handling for win64 vararg functions

[Mandeep Singh Grang via Phabricator via llvm-commits]

mgrang added a comment.

In https://reviews.llvm.org/D35919#827821, @mstorsjo wrote:

> In https://reviews.llvm.org/D35919#825156, @mstorsjo wrote:
>
> > @mgrang does this version fix all your issues with vararg functions, or are there still issues that can be traced back to this? With this in place, all of the test code I've tried to build seems to work. (Also, have you tried using lld-link for linking? It seems complete enough for coff/arm64 for me now.)
>
>
> Ping @mgrang - did this solve your issues with vararg functions, or is there still some case that I've missed?


Yes, so far we went past all issues related to varargs for spec2000. I think this patch LGTM. Also, we don't use lld-link for linking (we have an in-house ARM linker).


https://reviews.llvm.org/D35919