[PATCH] D35788: [DAGCombiner] Extending pattern detection for vector shuffle.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:14090
 
+  if (!(VecIn1 && VecIn2 && (VecIn1.getOpcode() == ISD::EXTRACT_SUBVECTOR) &&
+        (VecIn2.getOpcode() == ISD::EXTRACT_SUBVECTOR) &&
----------------
Is there any case where VecIn1 can be null? InVT1 above assumes not


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:14280
+      IndexVec[i] = Index;
+      MaxIndex = (MaxIndex < Index) ? Index : MaxIndex;
+    }
----------------
You can use std::max here


https://reviews.llvm.org/D35788