[PATCH] D36160: Liveness issues in tail merging, and the ARM::LR saved-but-not-restored

Krzysztof Parzyszek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 1 11:41:14 PDT 2017


kparzysz added a comment.

In https://reviews.llvm.org/D36160#827796, @efriedma wrote:

> If we are going to add a marking to CalleeSavedInfo, it would probably be better to add it in assignCalleeSavedSpillSlots, where we construct the CalleeSavedInfo, rather than waiting until restoreCalleeSavedRegisters.


The problem is that restoreCalleeSavedRegisters decides whether to use a pop instruction or not, which determines whether LR is restored, or loaded into PC directly.  Are you suggesting moving some of that logic into assignCalleeSavedSpillSlots?


Repository:
  rL LLVM

https://reviews.llvm.org/D36160





More information about the llvm-commits mailing list