[PATCH] D36140: [ELF] - Do not segfault if linkerscript tries to access Target too early.
Rafael Avila de Espindola via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 1 10:10:43 PDT 2017
Rui Ueyama via Phabricator <reviews at reviews.llvm.org> writes:
> Make this a member function of LinkerScript so that you don't need to pass `Location`.
Would it be the correct value? The code looks like:
std::string Location = getCurrentLocation();
...
if (Tok == "CONSTANT") {
StringRef Name = readParenLiteral();
return [=] { return getConstant(Name); };
so getCurrentLocation will be different after readParenLiteral(), no?
Cheers,
Rafael
More information about the llvm-commits
mailing list