[PATCH] D35014: [X86] PR32755 : Improvement in CodeGen instruction selection for LEAs.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: lib/Target/X86/X86OptimizeLEAs.cpp:159
+      hash_code h(0);
+      for (unsigned i = 1; i < MI->getNumOperands(); i++)
+        h = hash_combine(h, MI->getOperand(i));
----------------
(style)
```
for (unsigned i = 1, e = MI->getNumOperands(); i <e ; i++)
```


================
Comment at: lib/Target/X86/X86OptimizeLEAs.cpp:265
+    return false;
+  for (unsigned i = 1; i < MI1->getNumOperands(); ++i)
+    if (!isIdenticalOp(MI1->getOperand(i), MI2->getOperand(i)))
----------------
(style)
```
for (unsigned i = 1, e = MI1->getNumOperands(); i < e; ++i)
```


================
Comment at: test/CodeGen/X86/umul-with-overflow.ll:6
 define zeroext i1 @a(i32 %x)  nounwind {
+; CHECK-LABEL: a:
+; CHECK:       # BB#0:
----------------
RKSimon wrote:
> lsaba wrote:
> > jbhateja wrote:
> > > lsaba wrote:
> > > > why did this test change? 
> > > Beecause I generated its output with script utils/update_llc_test_checks.py which adds 
> > > an assertion for each instruction. I think it sould be fine. 
> > This needs to be in a separate pre commit. please commit and rebase 
> I regenerated this recently - please rebase
Still needs to be rebased - you've lost the x86_64 tests


https://reviews.llvm.org/D35014