[PATCH] D36152: [ARM] Add registers to debuginfo MIR test cases.

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 1 09:09:14 PDT 2017


MatzeB requested changes to this revision.
MatzeB added a comment.
This revision now requires changes to proceed.

In https://reviews.llvm.org/D36152#827603, @MatzeB wrote:

> BTW: mir has a feature nowadays, where you can say `%0 : gprnopc` the first time a vreg is used instead of declaring it in the registers list. Unfortunately the dumper doesn't know about it yet. You may want to switch to that style, though this is fine too.


I just realizes the vregs aren't even used, why are you adding 14 of them then and not just 1? This also seems odd enough that it warrants a comment in the .mir files.

The fix is also really strange. I've got this feeling this example really needs a `-start-after` or `-start-before` llc argument so it starts at a later pass which doesn't deal with vregs anymore. Maybe adrian remembers what `-stop-after` line he used to create these?


https://reviews.llvm.org/D36152





More information about the llvm-commits mailing list