[PATCH] D36114: [AsmPrinterDwarf] Add support for .cfi_restore directive

[Paul Robinson via Phabricator via llvm-commits]

probinson added inline comments.


================
Comment at: lib/CodeGen/MIRPrinter.cpp:1214
+    if (CFI.getLabel())
+      OS << "<mcsymbol> ";
+    printCFIRegister(CFI.getRegister(), OS, TRI);
----------------
I didn't see a test for this bit here.


================
Comment at: test/CodeGen/AArch64/cfi_restore.mir:4
+name:            fun
+# CHECK-LABEL: fun
+# CHECK: .cfi_startproc
----------------
Using CHECK-LABEL would seem to be unnecessary.
If it is necessary, using it with such a short name and no punctuation or other context is prone to matching something you didn't expect.


================
Comment at: test/CodeGen/MIR/AArch64/cfi.mir:22
+---
+name:            trivial_fp_func
+body: |
----------------
`CHECK-LABEL: name: trivial_fp_func`


================
Comment at: test/CodeGen/MIR/AArch64/cfi.mir:38
+---
+name:            trivial_fp_func_restore
+body: |
----------------
`CHECK-LABEL: name: trivial_fp_func_restore`


================
Comment at: test/MC/AArch64/cfi.s:4
+fun:
+// CHECK-LABEL: fun
+  .cfi_startproc
----------------
Remove unnecessary CHECK-LABEL


https://reviews.llvm.org/D36114