[PATCH] D35724: [ELF] - Fix missing relocation when linking executable with --unresolved-symbols=ignore-all

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 1 03:59:57 PDT 2017


>>>The change in this patch is to add "!symbol()->isWeak();"
>>>above. Shouldn't this case have been handled by includeInDynsym two ifs above?
>>
>> Not for --export-dynamic case. includeInDynsym() will return true earlier.
>
>Than is a bug in includeInDynsym. I fixed it in r309605.

Thanks ! Diff is updated too.

George.


More information about the llvm-commits mailing list