[PATCH] D35998: [TableGen] AsmMatcher: fix OpIdx computation when HasOptionalOperands is true

[Alexandru Guduleasa via Phabricator via llvm-commits]

alexandru.guduleasa added a comment.

Can you please tell which tests? And how did you ran them?

We ran the tests on a linux x64 machine, with the patch applied after commit:

  commit b779d345975e7346ce783d7d843e09706539c49e
  Author: Strahinja Petrovic <strahinja.petrovic at rt-rk.com>
  Date:   Fri Jul 28 12:54:57 2017 +0000
  
      [ARM] Add the option to directly access TLS pointer

The result were:

  Testing Time: 600.54s
    Expected Passes    : 20952
    Expected Failures  : 136
    Unsupported Tests  : 437
  [100%] Built target check-llvm

Cmake was ran with just the source directory (i.e. with all targets)

  cmake ../llvm

Maybe we are missing something.


https://reviews.llvm.org/D35998