[PATCH] D36059: [memops] Add a new pass to inject fast-path code for specific library function calls.

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: lib/Transforms/Scalar/FastPathLibCalls.cpp:90
+  /// Checks whether a value is known non-zero at a particular location.
+  bool isKnownNonZero(Value *V, Instruction &I) {
+    // If value tracking knows enough, we're done.
----------------
Is it better to rely on instcombine and cfg simplification to get rid of the redundant zero guard which can be more general?


================
Comment at: lib/Transforms/Scalar/FastPathLibCalls.cpp:147
+
+  struct FastPathMemOpFramework {
+    BasicBlock *HeadBB;
----------------
Framework can mean something much different. How about just call it 'Info'?


https://reviews.llvm.org/D36059