[PATCH] D18794: [Clang][BuiltIn][avx512] Adding builtins and tests to clang

[michael zuckerman via Phabricator via llvm-commits]

m_zuckerman abandoned this revision.
m_zuckerman added inline comments.


================
Comment at: include/clang/Basic/BuiltinsX86.def:1797
 TARGET_BUILTIN(__builtin_ia32_loadups256_mask, "V8fV8f*V8fUc","","avx512vl")
+TARGET_BUILTIN(__builtin_ia32_dbpsadbw512_mask, "V32sV64cV64cIiV32sUi","","avx512bw")
+TARGET_BUILTIN(__builtin_ia32_pbroadcastw512_mask, "V32sV8sV32sUi","","avx512f")
----------------
There is no implantation for this Buitlin. 


================
Comment at: lib/Headers/avx512bwintrin.h:1986
+                (__v64qi)( __B),\
+               ( __imm),\
+                (__v32hi)\
----------------
Aligns ( __imm) and all next 


================
Comment at: lib/Headers/avx512bwintrin.h:2020
+               (__v8di)( __B),\
+              ( __N) * 8,\
+               (__v8di)\
----------------
Aligns (  __N) and all next


================
Comment at: lib/Headers/avx512bwintrin.h:2032
+                   (__mmask64) -
+                   1);
+}
----------------
Delete extra line


================
Comment at: test/CodeGen/avx512vl-builtins.c:4449-4519
+__m128d test_mm_getmant_pd(__m128d __A, _MM_MANTISSA_NORM_ENUM __B, _MM_MANTISSA_SIGN_ENUM __C) {
+  // CHECK-LABEL: @test_mm_getmant_pd
+  // CHECK: @llvm.x86.avx512.mask.getmant.pd.128
+  return _mm_getmant_pd(__A, 1, 2); 
+}
+
+__m128d test_mm_mask_getmant_pd(__m128d __W, __mmask8 __U, __m128d __A, _MM_MANTISSA_NORM_ENUM __B, _MM_MANTISSA_SIGN_ENUM __C) {
----------------
Delete the MANTISSA argument


https://reviews.llvm.org/D18794