[PATCH] D35936: [ELF] - Move getSymbols() method to InputFile.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/InputFiles.h:89
+  // on files not of ObjectKind type.
+  ArrayRef<SymbolBody *> getObjSymbols() const {
+    assert(FileKind == ObjectKind);
----------------
Move the definition to the .cpp file.


================
Comment at: ELF/InputFiles.h:89
+  // on files not of ObjectKind type.
+  ArrayRef<SymbolBody *> getObjSymbols() const {
+    assert(FileKind == ObjectKind);
----------------
ruiu wrote:
> Move the definition to the .cpp file.
Do not rename this method unless it is needed. `getSymbols` should just work.


================
Comment at: ELF/InputFiles.h:92
+    if (SymbolBodies.empty())
+      return SymbolBodies;
+    return llvm::makeArrayRef(SymbolBodies).slice(1);
----------------
return {}


https://reviews.llvm.org/D35936