[PATCH] D36078: [XRay][compiler-rt] Remove use of std::mutex and std::shared_ptr from global scope.

[Dean Michael Berris via Phabricator via llvm-commits]

dberris added inline comments.


================
Comment at: lib/xray/xray_inmemory_log.cc:46
 
-std::mutex LogMutex;
+__sanitizer::SpinMutex LogMutex;
 
----------------
dblaikie wrote:
> Might be worth separating these two changes (the mutex from the shared-ptr) - they seem pretty independent & this one looks like it's good forward progress to move away from standard library dependencies as is required by compiler-rt, the other's more of a stop-gap (or at least neutral on the progress in that direction).
Thought about it, but for efficiency's sake, I suspect I'd like to make both changes as a group. They're both trying to achieve the same thing (no complex/atomic initialisation at init-time) and are working towards the same (partial) goal.


================
Comment at: lib/xray/xray_inmemory_log.cc:85-86
   static bool TSCSupported = probeRequiredCPUFeatures();
-  static uint64_t CycleFrequency = TSCSupported ? getTSCFrequency()
-                                   : __xray::NanosecondsPerSecond;
+  static uint64_t CycleFrequency =
+      TSCSupported ? getTSCFrequency() : __xray::NanosecondsPerSecond;
 
----------------
dblaikie wrote:
> unnecessary reformatting? or did something change in this line that I can't quite spot.
Looks like this wasn't formatted correctly before, and clang-format did the needful for me. :)


https://reviews.llvm.org/D36078