[PATCH] D36111: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 31 13:35:20 PDT 2017


mstorsjo added inline comments.


================
Comment at: include/clang/Basic/BuiltinsAArch64.def:49
 // Memory barrier
+BUILTIN(__dmb, "vUi", "nc")
+BUILTIN(__dsb, "vUi", "nc")
----------------
Shouldn't these be limited to MSVC mode only? Have a look at `BuiltinsARM.def`, where there's cases like `LANGBUILTIN(__dmb, "vUi", "nc", ALL_MS_LANGUAGES)` instead.


https://reviews.llvm.org/D36111





More information about the llvm-commits mailing list