[PATCH] D36060: [AsmParser][GAS-compatibility] Ignore an empty 'p2align' directive
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 31 12:47:14 PDT 2017
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
================
Comment at: lib/MC/MCParser/AsmParser.cpp:3223
+ return addErrorSuffix(" in directive");
+ // GAS-Compatibility: Ignore empty '.p2align', but add a warning
+ if (IsPow2 && (ValueSize == 1) && getTok().is(AsmToken::EndOfStatement)) {
----------------
I'd reword this to be a normal sentence, something like:
// Ignore empty '.p2align' directives for gnu-as compatibility.
Repository:
rL LLVM
https://reviews.llvm.org/D36060
More information about the llvm-commits
mailing list