[PATCH] D36073: [CGP] Extends the scope of optimizeMemoryInst optimization

Daniel Berlin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 31 10:40:49 PDT 2017


dberlin added inline comments.


================
Comment at: lib/CodeGen/CodeGenPrepare.cpp:4381
+// Try to match PHI node to Candidate. Matcher tracks the matched Phi nodes.
+static bool MatchPhiNode(PHINode *PHI, PHINode *Candidate,
+                         DenseSet<PHIPair> &Matcher,
----------------
FWIW, i'd just hash them, rather thancheck the possible matches again and again, i think.

Happy to give you some code to crib for that.




https://reviews.llvm.org/D36073





More information about the llvm-commits mailing list