[PATCH] D30703: [DSE] Merge stores when the later store only writes to memory locations the early store also wrote to.

Sanjoy Das via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 31 10:00:26 PDT 2017


sanjoy accepted this revision.
sanjoy added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Transforms/Scalar/DeadStoreElimination.cpp:446
+  // Check for an earlier store which writes to all the memory locations that
+  // the latter store writes to.
+  if (EnablePartialStoreMerging && LaterOff >= EarlierOff &&
----------------
latter is correct, but I'd s/latter/later/ since that's what the source says.


================
Comment at: lib/Transforms/Scalar/DeadStoreElimination.cpp:1213
+
+            //// Delete the old stores and now-dead instructions that feed them.
+            deleteDeadInstruction(Inst, &BBI, *MD, *TLI, IOL, &InstrOrdering);
----------------
s|`////`|`//`|


https://reviews.llvm.org/D30703





More information about the llvm-commits mailing list