[PATCH] D36061: [MSP430] Implement multiplication by a constant
Vadzim Dambrouski via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 31 07:53:30 PDT 2017
pftbest added a comment.
> This looks like target-independent code
You are right, `genConstMult` function is target-independent.
> make it part of the default lowering
I don't think that would work, because we use this function differently.
Mips is calling it from DAGCombine, but MSP430 needs it for lowering.
> please turn it into a target-independent utility
Can you please suggest where can I put this function? I've never heard about target-independent utilities.
https://reviews.llvm.org/D36061
More information about the llvm-commits
mailing list