[PATCH] D36065: [llvm-dlltool] Write correct weak externals

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 31 03:03:45 PDT 2017


ruiu accepted this revision.
ruiu added a comment.

LGTM



================
Comment at: lib/Object/COFFImportFile.cpp:549
+  StringRef Prefix = Imp ? "__imp_" : "";
+  SymbolTable[3].Name.Offset.Offset = sizeof(uint32_t) + Sym.size() + Prefix.size() + 1;
   append(Buffer, SymbolTable);
----------------
Please keep it in 80 cols.


https://reviews.llvm.org/D36065





More information about the llvm-commits mailing list