[PATCH] D35742: [Driver] Register effective triple before get arm float abi.

[Peter Smith via Phabricator via llvm-commits]

peter.smith added a comment.

Thanks for adding the extra tests. It seems like getARMFloatABI used to compute its own EffectiveTriple but this was changed to retrieve a cached value https://reviews.llvm.org/D22596, this is a pity for options . With this in mind I think putting the RegisterEffectiveTriple within the scope of OPT_print_libgcc_file_name. I agree with compnerd that hoisting it out of the switch makes the flow of the code easier to read, but no strong opinions. No further comments from me.


https://reviews.llvm.org/D35742