[PATCH] D35474: SSAUpdater: Add mode when Phi creation is not allowed

[Serguei Katkov via Phabricator via llvm-commits]

skatkov abandoned this revision.
skatkov added a comment.

Hi Daniel,

I've come up with the following implementation basing on your idea: https://reviews.llvm.org/D36073

Please take into account that finally I realized that I could not use SSAUpdater API because it is possible that I can observe the base instruction in the same BB but the difference might be in the path I can get it.
Simple example:
p1 = b1 + 40
p2 = b2 + 40
p = p1
if (cond) p = p2
v = *(p)

So I have p1 and p2 in the same basic block, so I cannot say to SSA update that I saw b1 and b2 in the same basic block to get the right phi node merging b1 and b2.
I hope the right implementation may b found in https://reviews.llvm.org/D36073


https://reviews.llvm.org/D35474