[PATCH] D35043: [ADT] Enable reverse iteration for DenseMap

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: include/llvm/Support/ReverseIteration.h:10
+template<class T = void*>
+static bool shouldReverseIterate() {
 #if LLVM_ENABLE_REVERSE_ITERATION
----------------
mgrang wrote:
> @dblaikie Is this implementation similar to what you had in mind when you said shouldReverseIterate should be a compile time constant w/o the need for an out-of-line definition?
Yep, looks about right to me - though it shouldn't be static (shouldn't have internal linkage (non-class scoped static/anonymous namespace) things in headers)


Repository:
  rL LLVM

https://reviews.llvm.org/D35043