[PATCH] D36059: [memops] Add a new pass to inject fast-path code for specific library function calls.

Serge Pavlov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 30 09:46:47 PDT 2017


sepavloff added a comment.

What is advantage of making this transformation a separate pass instead of doing it during selection?

Some targets do not have support library and always expand mem intrinsics, the code making expansion is in `LowerMemIntrinsics.cpp`. Does it make sense to combine these implementations?



================
Comment at: lib/Transforms/Scalar/FastPathLibCalls.cpp:443
+
+  DT.verifyDomTree();
+
----------------
Probably this function should be called only when `VerifyDomInfo` is `true` to reduce compile time?


https://reviews.llvm.org/D36059





More information about the llvm-commits mailing list