[PATCH] D36053: Refactor the build{Module|Function}SimplificationPipeline to expose optimization phase.
Chandler Carruth via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Jul 29 20:36:10 PDT 2017
chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.
LGTM with a comment wording tweak below. Thanks for he refactoring!
================
Comment at: include/llvm/Passes/PassBuilder.h:229
///
- /// \p PrepareForThinLTO indicates whether this is invoked in
- /// PrepareForThinLTO phase. Special handling is needed for sample PGO to
- /// ensure profile accurate in the backend profile annotation phase.
+ /// \p Phase indicates the current optimization phase.
FunctionPassManager
----------------
"the current optimization phase" -> "the current ThinLTO phase", here and below where the same phrasing is used.
https://reviews.llvm.org/D36053
More information about the llvm-commits
mailing list