[PATCH] D36042: Move GVNExpression DenseMapInfo to GVNExpression.h

River Riddle via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 28 19:38:59 PDT 2017


It okay, it came out a little bit cleaner with the specialized version. If
we ever want to move a relaxed equivalency expression to NewGVN it will be
trivial to add it back :)

-- River

On Fri, Jul 28, 2017 at 7:34 PM, Daniel Berlin <dberlin at dberlin.org> wrote:

> I mean, you are welcome to reuse it, I was just trying to understand what
> for :)
>
>
> On Fri, Jul 28, 2017 at 6:29 PM, River Riddle <riddleriver at gmail.com>
> wrote:
>
>> I use it for a custom GVNExpression that I created for detecting relaxed
>> equivalency between instructions. I use this in the IR level outliner(code
>> folder) that I am posting a patch for soon. I suppose I could just define a
>> DenseMapInfo for that expression type.
>>
>> -- River
>>
>> On Fri, Jul 28, 2017 at 6:24 PM, Daniel Berlin <dberlin at dberlin.org>
>> wrote:
>>
>>> Why?
>>>
>>>
>>>
>>> On Fri, Jul 28, 2017 at 5:51 PM, River Riddle via Phabricator <
>>> reviews at reviews.llvm.org> wrote:
>>>
>>>> rriddle created this revision.
>>>> Herald added a subscriber: Prazek.
>>>>
>>>> Make the DenseMapInfo for GVNExpression available outside of NewGVN.
>>>>
>>>>
>>>> https://reviews.llvm.org/D36042
>>>>
>>>> Files:
>>>>   include/llvm/Transforms/Scalar/GVNExpression.h
>>>>   lib/Transforms/Scalar/NewGVN.cpp
>>>>
>>>>
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170728/ab7ffc31/attachment.html>


More information about the llvm-commits mailing list