[PATCH] D36031: [sanitizer_common] Fuchsia OS support code

[Roland McGrath via Phabricator via llvm-commits]

mcgrathr added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_printf.cc:260
+    // Fuchsia's logging infrastructure always keeps track of the logging
+    // process, thread, and timestamp, so never prepend such information.
+    if (!SANITIZER_FUCHSIA && append_pid) {
----------------
vitalybuka wrote:
> I guess you would like to enabled as many as possible compiler-rt tests in future
> So maybe better to avoid diverging if this is not critical?
> 
> 
I will be getting the tests going at some point.
The logging story is very different on Fuchsia, so there will be a bunch more work in getting the tests right.
We absolutely do not want the sanitizer logging to do this kind of tagging for Fuchsia.


Repository:
  rL LLVM

https://reviews.llvm.org/D36031